Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some filename fixes #29

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Added some filename fixes #29

merged 2 commits into from
Mar 16, 2022

Conversation

Emersont1
Copy link
Owner

Hopefully this will fix the issues in #28

Can you test it on the one it wasn't working on before with these fixes please

# clone the repo
git clone https://github.com/Emersont1/itchio

# checkout to filename-fixes
cd itchio
git checkout filename-fixes

# create and load a venv
python -m venv venv
source venv/bin/activate

# install
pip install .

# profit?
python -m itchiodl.downloader -k INSERT_API_KEY_HERE

@TheFrenchGhosty
Copy link

Tested, it now breaks on "nothing":

Skipping Game Staxter
Traceback (most recent call last):
  File "/home/user/.local/bin/itch-download", line 8, in <module>
    sys.exit(main())
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/downloader/__main__.py", line 31, in main
    lib.download_library()
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/library.py", line 35, in download_library
    game.download(self.login)
  File "/home/user/.local/lib/python3.10/site-packages/itchiodl/game.py", line 68, in download
    itchiodl.utils.download(url, path, self.name + " - " + file)
TypeError: download() missing 1 required positional argument: 'file'

@Emersont1
Copy link
Owner Author

can you try with the second commit, turns out I was a numpty with the changes

@TheFrenchGhosty
Copy link

@Emersont1 Worked perfectly!

@Emersont1
Copy link
Owner Author

smashing! I'll merge that in

@Emersont1 Emersont1 merged commit ae960bc into main Mar 16, 2022
@Emersont1 Emersont1 deleted the filename-fixes branch March 27, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash - AttributeError: 'NoneType' object has no attribute 'group'
2 participants