Feat time correction #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2022
Merged
src/ofxLSLReceiver.h
Outdated
| @@ -75,6 +80,7 @@ class Receiver : public BaseReceiver { | |||
| sampleBuffer->timeStamp = ts; | |||
| if (ts > 0) { | |||
| std::lock_guard<std::mutex> lock(pullMutex); | |||
| sampleBuffer->timeCorrection = getTimeCorrection(1); // update the time correction value when pulling sample | |||
There was a problem hiding this comment.
What does a timeout return?
Are we able to handle that case reasonably downstream?
There was a problem hiding this comment.
Tested by making timenot = 0.1s. (getTimeCorrection(0.1)), and the example threw a lsl::timeout exception.
There was a problem hiding this comment.
According to the library,
param timeout Timeout to acquire the first time-correction estimate (default: no timeout).
Looks like this timeout is only for the first correction. So it is better to remove the timeout all together, since it only affects the first reading.
There was a problem hiding this comment.
Tested working. If the stream is lost, it tries to reconnect to the stream.
|
✔️ merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description