Add travis #57
Merged
Add travis #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are some old tickets referencing 2.1 vs 2.2 behavior, so I'm locking to old gems just to allow travis to build 2.1 while that's sorted out.
|
If you want to see what this will do, I set it up on my fork of the repo. See: https://travis-ci.org/lostapathy/roxml/builds |
Added conditionals around specs that rely on behavior that is not present in all ruby versions. If ruby-2.1 support is dropped in the future, we need to come back and remove spec/regression_spec.rb as it no longer applies in ruby-2.2 and later.
|
I added a third commit here that resolves the travis failures. Also Resolves #51. Up to you whether we support ruby-2.1 (or older) or if we could update the gemspec to require 2.2 or newer. I'm guessing people looking to upgrade this gem are more worried about ruby-2.4 support and less worried about upgrading with old versions of ruby. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a super basic travis build config and adds a badge to the README.
Before merging, you'll need to tell travis to start watching this project by going to https://travis-ci.org/Empact/roxml
There are currently test failures in the project, I'll try to work through those on separate PRs.
Long term I would like to take ruby-2.1.10 back out of the travis config (since it's no longer supported) but I thought it couldn't hurt to test farther back while bringing this project back up to speed. Bundler doesn't seem to be able to come up with a way to build the project with ruby-2.0 or older, or I would have gone back farther for now.