use URI::DEFAULT_PARSER to get rid of deprecation warning #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels like a bit of a hack to get rid of the deprecation warning but seemed to be the simplest way. From what I can tell,
URI.escape
andURI.unescape
have been deprecated because they shouldn't be used to escape actual URIs. In this case though we aren't using them to escape URIs and none of the recommended replacements (CGI.escape
,URI.encode_www_form
orURI.encode_www_form_component
) allow only escaping specific characters which is the behavior we want.I didn't add a spec because this is doesn't meaningfully change the code (
URI.escape
/URI.unescape
already delegate toURI::DEFAULT_PARSER
) andtest_xml_name_not_screwed_up_by_xml_convention
already tests this behavior.Fixes #71