-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add support for compact representations in input and output #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LcyDev
changed the title
[Feature]: Add support for metric compact representations in both
[Feature]: Add support for compact representations in input and output
Jul 30, 2023
@EncryptSL Please review my rebased pull request. |
Testing Unit
|
EncryptSL
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me.
LcyDev
added
Improvements
New improvements
NotBug
This is a not bug.
Approved
Status approved
Priority Low
Priorioty Low
labels
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Status approved
Improvements
New improvements
NotBug
This is a not bug.
Priority Low
Priorioty Low
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for compact representations, converting large numbers in a more concise format.
Additionally, the code for amount validation in
MoneyCMD
has been refactored to improve code maintainability.About:
Compact representations are used to abbreviate large numeric values using metric prefixes, to make them more human-readable. Allowing to represent billions as
1.5B
These changes will enhance user experience and it provides better flexibility to manage how numeric values are represented.
Issues related:
Changed incorporated:
MoneyCMD
format_amount_error
plugin.economy.compact_display