Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Add Kubernetes 1.9 and Helm 2.8.2 support #124

Merged
merged 11 commits into from Jun 21, 2018
Merged

Add Kubernetes 1.9 and Helm 2.8.2 support #124

merged 11 commits into from Jun 21, 2018

Conversation

carlosjgp
Copy link
Contributor

@carlosjgp carlosjgp commented Jun 7, 2018

Fixes #121

I think I need a hand here.

This is the first time I do GoLang, I sort out all the dependencies and tests are passing but Landscaper can't retrieve Tiller version for some reason I don't understand

I'll appreciate some guidance here if you have some time

Thanks!

@carlosjgp
Copy link
Contributor Author

By the way, this is the output I get when I ran Landscaper

https://gist.github.com/carlosjgp/65dfc17de5a759cc98265bb8d340be54

@carlosjgp
Copy link
Contributor Author

I found the problem

Helm requires a timeout option which has no default on 2.8.2
https://github.com/kubernetes/helm/blob/v2.8.2/pkg/helm/client.go#L47

But it does have a default value on 2.9.1
https://github.com/kubernetes/helm/blob/v2.9.1/pkg/helm/client.go#L48

Now is working!

Copy link
Collaborator

@rollulus rollulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the help! Getting those dependencies right isn't the most fun part, much appreciated. Content looks good to me but I've been out of the loop for a while, so I'll prefer a thumbs up from another contributor (@johnhofman ?) One thing though: could you be so kind to change your commit message so that they adhere to semantic commit messages? This will keep the auto-generated change log consistent. Thanks!

@rollulus rollulus requested a review from johnhofman June 12, 2018 07:46
@carlosjgp
Copy link
Contributor Author

Thanks for the feedback. I'm going to amend the messages right now

@rollulus rollulus merged commit 01794fb into Eneco:master Jun 21, 2018
@rollulus
Copy link
Collaborator

Thanks!

@carlosjgp carlosjgp deleted the k8s1_9 branch June 21, 2018 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants