-
Notifications
You must be signed in to change notification settings - Fork 31
Add Kubernetes 1.9 and Helm 2.8.2 support #124
Conversation
By the way, this is the output I get when I ran Landscaper https://gist.github.com/carlosjgp/65dfc17de5a759cc98265bb8d340be54 |
I found the problem Helm requires a timeout option which has no default on But it does have a default value on Now is working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the help! Getting those dependencies right isn't the most fun part, much appreciated. Content looks good to me but I've been out of the loop for a while, so I'll prefer a thumbs up from another contributor (@johnhofman ?) One thing though: could you be so kind to change your commit message so that they adhere to semantic commit messages? This will keep the auto-generated change log consistent. Thanks!
Thanks for the feedback. I'm going to amend the messages right now |
Kubernetes has moved some of their Go files into another location. Next step is fix the imports
Thanks! |
Fixes #121
I think I need a hand here.
This is the first time I do GoLang, I sort out all the dependencies and tests are passing but Landscaper can't retrieve Tiller version for some reason I don't understand
I'll appreciate some guidance here if you have some time
Thanks!