Fix alwaysOn bug. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption_dataframe`.
martintamke
approved these changes
Jan 29, 2018
There was a problem hiding this comment.
Hello JrtPec - the changes to the code look good to me. I think anyone, who needs to stock with the old getconsumption approach is well off with the "raw" flag.
However Wh makes more sense, than a 5min block.
Thank you very much for your quick work - please merge with the Master.
|
@martintamke Great! Version 0.2.15 was published to pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24
Fixes 'alwaysOn' bug, where values were not given in Wh by the server.
Add
rawflag toget_consumptionandget_consumption_dataframe, if you want to get the data "as is" from the server.