-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP .hdr writer #31
WIP .hdr writer #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, in terms of what we currently have here, I don't happen to see anything egregiously bad or non-fancy. However, it would be nice to see how we can solve the major problems of writing files from here (as indicated in #19). Future versions should indeed become less and less independent from ndarray
for writing.
What I don't like is the
and the fact that the same logic will also be duplicated in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I can't think of a way to simplify those if-else statements without moving those pieces into separate functions, which I don't think is necessary. However, a few other things to consider below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. I have a few other concerns that I wish to attend before making a new release, but we'll deal with those separately. Thanks!
WIP because
write_nifti
is so ugly now that I didn't found the courage to makewrite_rgb_nifti
work too. I would be really interested in your review. Like, how I can make this less ugly. Or even beautiful!I added a lot of
#[cfg(feature = "ndarray_volumes")]
foris_hdr_file
because it's currently only used withndarray_volumes
, but this will be removed "soon" when we support writing nifti-rs types.