Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double drawing and proper number of verts #767

Merged
merged 4 commits into from
Mar 6, 2021
Merged

Conversation

Noofbiz
Copy link
Member

@Noofbiz Noofbiz commented Mar 5, 2021

I was counting the vertex that sets it to the center as a vertex that draws the circle, which led to an off-by-one offset in the circle. This caused the angles to be a little smaller than they should've been when using Circle.Arc, as well as double drawing of some triangles when the transparency was set to something other than 1 or 0.

Fixes for #766

@Noofbiz Noofbiz mentioned this pull request Mar 5, 2021
@Noofbiz Noofbiz changed the title Double drawing and proper number of verbs Double drawing and proper number of verts Mar 5, 2021
@coveralls
Copy link

coveralls commented Mar 5, 2021

Coverage Status

Coverage remained the same at 40.922% when pulling 6405c04 on draw-circle-borders into f59b4f0 on master.

@Noofbiz Noofbiz merged commit 32f0ebe into master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants