Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmx: fix the tmx/tsx loading #768

Merged
merged 1 commit into from
Mar 14, 2021
Merged

tmx: fix the tmx/tsx loading #768

merged 1 commit into from
Mar 14, 2021

Conversation

faide
Copy link
Contributor

@faide faide commented Mar 14, 2021

Hello,

this little patch fixes an issue when trying to load tmx files that reference tsx files

it tries to be as unobtrusive as possible by defining a new interface and only using it if the given file loader supports this new interface.

Cheers,
Florent

@eth0net
Copy link
Contributor

eth0net commented Mar 14, 2021

Oo nice! This will help me out for sure, I meant to look at this but ended up embedding the TSX contents in the TMX 🤷🏼‍♀️

Look forward to trying this out as a better solution though!

@faide
Copy link
Contributor Author

faide commented Mar 14, 2021

Hello project members,

I see some qa tests failing but they are on the audio system I did not touch. Does anyone know what is going on here ?

@faide
Copy link
Contributor Author

faide commented Mar 14, 2021

I fixed the tests locally lets see if all passes

@coveralls
Copy link

coveralls commented Mar 14, 2021

Coverage Status

Coverage increased (+0.01%) to 40.936% when pulling ee419c2 on faide:master into 32f0ebe on EngoEngine:master.

@Noofbiz
Copy link
Member

Noofbiz commented Mar 14, 2021

Looks good to me. The audio stuff is just stuff I haven't figured out how to test well yet. It doesn't affect whether tests pass or fail. Thanks for the contribution!

@Noofbiz Noofbiz merged commit b700def into EngoEngine:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants