Fluid registry rework #5435
Merged
Fluid registry rework #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsPilgaard
approved these changes
Dec 30, 2023
NielsPilgaard
merged commit d5d22f6
into
EnigmaticaModpacks:develop
5 of 7 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from ZZZank@9e9b9a9
There's nothing destructive in this PR, just refactor scripts for fluid registry.
The arg
displayis now deprecated, in favor of using lang file(en_us.json) , so that localization can be easier.But, if someone uses
display, it will still properly set the displayName of targeted fluid as before, but a warning will be printed into the log.There's also some tips to help devs move from using
displayto usingen_us.json.