Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit shuffle result #2

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from
Draft

Commit shuffle result #2

wants to merge 71 commits into from

Conversation

EnricoMi
Copy link
Owner

@EnricoMi EnricoMi commented Feb 3, 2024

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: # (issue)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

No.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

- use mapIndex instead of taskAttemptId in blockId
- offer and commit blockIds of taskAttemptId for mapIndex
- remove partitions from request
- drop multi partition impl
- fix log messages
- remove start and end partition and map index
Copy link

github-actions bot commented Feb 4, 2024

Test Results (pull_request)

2 193 files  2 193 suites   3h 50m 45s ⏱️
  711 tests   710 ✅  1 💤 0 ❌
8 874 runs  8 861 ✅ 13 💤 0 ❌

Results for commit f83960f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 4, 2024

Test Results (push)

0 files   - 2 287  0 suites   - 2 287   0s ⏱️ - 4h 27m 27s
0 tests  -   818  0 ✅  -   817  0 💤  -  1  0 ❌ ±0 
0 runs   - 9 077  0 ✅  - 9 064  0 💤  - 13  0 ❌ ±0 

Results for commit c063246. ± Comparison against base commit 076bf8b.

♻️ This comment has been updated with latest results.

zuston pushed a commit to apache/incubator-uniffle that referenced this pull request Feb 5, 2024
### What changes were proposed in this pull request?
Reports test results in Github UI.

### Why are the changes needed?
Individual results of test failures are easier to access than scrolling through long job logs: [example](https://github.com/EnricoMi/incubator-uniffle/runs/21197842666)
Test stats are nicely presented in corresponding pull request: EnricoMi#2 (comment)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manual.
Copy link

github-actions bot commented Feb 5, 2024

Test Results (workflow_dispatch)

2 180 files  2 180 suites   3h 46m 14s ⏱️
  710 tests   707 ✅  1 💤 1 ❌ 1 🔥
8 848 runs  8 831 ✅ 13 💤 3 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit b47f2e8.

@EnricoMi EnricoMi force-pushed the master branch 2 times, most recently from 866f90c to 767c6af Compare February 27, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant