New architecture: Replace PublicItemBuilder with ItemIterator
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main benefits of this new architecture is that we behave properly when: * A single item is imported in several places * An item is (publicly) imported from another crate
The special thing with thiserror is that it depends on a thiserror-impl and re-exports an item from that crate. The new ItemIterator implementation can handle this, but the old PublicItemBuilder implementation could not. This is a regression test for the fix to #11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of iterating over all items with crate_id 0, follow referenced items from the crate root. The main benefits of this new architecture is that we behave properly when:
Fixes #11