-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/payuk firewall rules #116
Conversation
Why has the PR template been cut short? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now. It would be good to provide a list of your own custom rules but looks like that isn't possible from what you have said. This PR is just allowing us to turn on/off a custom alert tls rule which is fine.
This is much better thanks, as now we have some control over what is happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK happy with this now
📲 What
Adding custom firewall rules that is going to be implemented in a project but using a toggle variable to keep it off form the generic implementation.
There is a issue as discussed here that results in tight coupling of the policy and rule groups for now, which might get remediated in future release.
hashicorp/terraform-provider-aws#28100
hashicorp/terraform-provider-aws#34956
🤔 Why
Add additional tls alert rule.
🛠 How
By using dynamic block and custom toggle variable to configure TLS Alert rule.
👀 Evidence
In Customer PR (i.e in the root module PR) there is an attached build log and aws snapshot for the deployment.
🕵️ How to test
By toggling the variable on in the root module when enabling firewall feature
✅ Acceptance criteria Checklist