Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/payuk firewall rules #116

Merged
merged 21 commits into from
Apr 15, 2024
Merged

Feat/payuk firewall rules #116

merged 21 commits into from
Apr 15, 2024

Conversation

dibyadhar
Copy link
Contributor

@dibyadhar dibyadhar commented Apr 11, 2024

📲 What

Adding custom firewall rules that is going to be implemented in a project but using a toggle variable to keep it off form the generic implementation.

There is a issue as discussed here that results in tight coupling of the policy and rule groups for now, which might get remediated in future release.

hashicorp/terraform-provider-aws#28100
hashicorp/terraform-provider-aws#34956

🤔 Why

Add additional tls alert rule.

🛠 How

By using dynamic block and custom toggle variable to configure TLS Alert rule.

👀 Evidence

In Customer PR (i.e in the root module PR) there is an attached build log and aws snapshot for the deployment.

image

🕵️ How to test

By toggling the variable on in the root module when enabling firewall feature

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@russellseymour
Copy link
Contributor

Why has the PR template been cut short?
It should have th What, How, Why and evidence that things are working when it is deployed.

Copy link
Contributor

@balpurewal balpurewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. It would be good to provide a list of your own custom rules but looks like that isn't possible from what you have said. This PR is just allowing us to turn on/off a custom alert tls rule which is fine.

@russellseymour
Copy link
Contributor

This is much better thanks, as now we have some control over what is happening.

Copy link
Contributor

@russellseymour russellseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK happy with this now

@dibyadhar dibyadhar merged commit 71460ce into master Apr 15, 2024
2 checks passed
@dibyadhar dibyadhar deleted the feat/payuk-firewall-rules branch April 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants