Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding post deploy step needed for slack notifications #11654

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

dwhitestratiform
Copy link
Contributor

@dwhitestratiform dwhitestratiform commented Apr 3, 2024

Description

This is a chicken and egg problem. This workflow needs to exist on main before I can test and use it in a development branch. So here I am.

After this is pushed to main I can pull this into my dev branch and actually use it.

Related ticket(s)


How to test

Push and verify this doesn't break the mcr main deploy ... I tested this in core and it worked.

Notes


Pre-review checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@dwhitestratiform
Copy link
Contributor Author

this will never pass PR steps because its a skipci branch ... going to merge and keep an eye on main to make sure it passes.

@dwhitestratiform dwhitestratiform merged commit 17aaf97 into main Apr 3, 2024
10 checks passed
@dwhitestratiform dwhitestratiform deleted the skipci-adding-post-deploy-step branch April 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants