Types Cleanup

[karla-vm]

Description

Cleaning up the types across ui-src and app-api for better understanding in the future.

Related ticket(s)

N/A

---

How to test

There should be no functional changes in this PR.

Notes

N/A

---

Pre-review checklist

• I have added thorough tests, if necessary
• I have updated relevant documentation, if necessary
• I have performed a self-review of my code
• I have manually tested this PR in the deployed cloud environment

---

Pre-merge checklist

Review

• Design: This work has been reviewed and approved by design, if necessary
• Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

• These changes are significant enough to require an update to the SIA.
• These changes are significant enough to require a penetration test.

---

convert to a different template: test → val | val → prod

[gmrabian]

I know some of these are unused and may be used in the future, but just want to be careful about what we assume is important to both sides. ex: I think ReportMetadata should absolutely be in both and should match. That is an essential part of the fe/be contract. S3EventRecordGlacierRestoreEventData though? If the FE ever needs that one we are doing something wrong.

Do we have a plan for the next phase? Is there a way to tighten up the ones we need in both and the ones we don't?

[codeclimate]

Code Climate has analyzed commit b34e0cc and detected 31 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	31

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.1% change).

View more on Code Climate.