Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDCT-1979: Delete Measure Details #4222

Merged
merged 43 commits into from
Oct 6, 2022
Merged

MDCT-1979: Delete Measure Details #4222

merged 43 commits into from
Oct 6, 2022

Conversation

ntsummers1
Copy link
Contributor

Description

A measured response for a measured entity
Fixes MDCT-1979

Screen.Recording.2022-10-04.at.2.48.08.PM.mov

How to test

./dev local
Create a program
Enter Program
Go to mcpar/program-level-indicators/availability-and-accessibility/access-measures
Add a few access measures
Delete however many you want!

Changed Dependencies

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

braxex and others added 26 commits September 30, 2022 13:27
@braxex
unnest pages in report json
67f0a91
@braxex
refactor spreadsheet
ed1e5d0
@braxex
fix all types and prepare drawer and modal forms'
be63d7e
@braxex
final type tweaks
0c91cb3
@braxex
update copyAdminDisabledStatusToForms utility method
c73a5b4
@braxex
add more tests for utility methods
43ff3e4
@braxex
build add/edit modal; style initial page
40dff7f
@braxex
solve overwrite issue
747f3e9
@braxex
build out card with no functionality
662978d
@braxex
DynamicDrawerReportPage tests
da84664
@braxex
merge in main
b107923
@braxex
EntityDrawerReportPage → DrawerReportPage
4dd5fe0
@braxex
DynamicDrawerReportPage → ModalDrawerReportPage
48c11fb
@braxex
merge in naming changes
4e62a7d
@braxex
switch from record to entity
ba177ef
@braxex
change dynamicType to entityType
426412b
@braxex
fix failing test
de75390
@braxex
add AddEditEntityModal tests
313d91d
Implement simple deletion of entities
e301d27
Merge branch 'dynamic-drawer-step-1' into mdct-1979
ebb0f5f
@braxex
add EntityCard tests
91ca4a1
@braxex
final styling and such"
7f40aff
Add tests for DeleteEntityModal
6bf24ad
Merge branch 'dynamic-drawer-step-1' into mdct-1979
498f3a8
Add EntityCard test
bbd2424
fix bug with adding after deleting measures
d94c9dc
@ntsummers1 ntsummers1 self-assigned this Oct 4, 2022
@ntsummers1 ntsummers1 marked this pull request as ready for review October 4, 2022 19:05
@ntsummers1 ntsummers1 changed the title [Draft] MDCT-1979: Delete Measure Details MDCT-1979: Delete Measure Details Oct 4, 2022
braxex
braxex approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@braxex braxex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few comments/suggestions but nothing blocking. 👍

services/ui-src/src/components/modals/DeleteEntityModal.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/modals/DeleteEntityModal.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/reports/ModalDrawerReportPage.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/reports/ModalDrawerReportPage.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/modals/DeleteEntityModal.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/modals/DeleteEntityModal.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/modals/DeleteEntityModal.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/modals/DeleteEntityModal.tsx Outdated Show resolved Hide resolved
gmrabian
gmrabian reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Curious to get your take on my idea for abstracting these similar components

Base automatically changed from dynamic-drawer-step-1 to main October 6, 2022 13:41
@ntsummers1 ntsummers1 merged commit 9d43e0b into main Oct 6, 2022
@ntsummers1 ntsummers1 deleted the mdct-1979 branch October 6, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braxex braxex braxex approved these changes

@gmrabian gmrabian gmrabian approved these changes

@karla-vm karla-vm Awaiting requested review from karla-vm karla-vm is a code owner

@TheDanMiller TheDanMiller Awaiting requested review from TheDanMiller

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@juliuscaesar juliuscaesar Awaiting requested review from juliuscaesar

@scwambach scwambach Awaiting requested review from scwambach

@britt-mo britt-mo Awaiting requested review from britt-mo

Assignees

@ntsummers1 ntsummers1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntsummers1 @braxex @gmrabian