Mdct 2000 #4236
Merged
Mdct 2000 #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scwambach
requested review from
karla-vm,
TheDanMiller,
BearHanded,
braxex,
gmrabian,
ntsummers1,
juliuscaesar and
britt-mo
as code owners
gmrabian
reviewed
Oct 5, 2022
| @@ -24,6 +25,7 @@ export const Form = ({ | |||
| ...props | |||
| }: Props) => { | |||
| const { fields, options } = formJson; | |||
| const selectedReport = localStorage.getItem("selectedReport"); | |||
There was a problem hiding this comment.
I think this is gonna be a problem for non-report forms, like the admin banner page.
There was a problem hiding this comment.
@gmrabian I got a solution added in for the admin banner, let me know what you think
gmrabian
requested changes
Oct 5, 2022
gmrabian
reviewed
Oct 5, 2022
There was a problem hiding this comment.
I think you could even abstract this one level further and put it in the ReportPageWrapper, which renders each of the StandardReportPage, DrawerReportPage, and ModalDrawerReportPage
Wrap this in a spinner: https://github.com/CMSgov/mdct-mcr/blob/main/services/ui-src/src/components/reports/ReportPageWrapper.tsx#L77 ?
That's what I understood from the slack thread
gmrabian
approved these changes
Oct 5, 2022
gmrabian
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a loading state for hydrating field values
How to test
Click through a form that's been filled out and watch the spinner spin!
Changed Dependencies
Code author checklist
Reviewer checklist (two different people)