Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit access measure details (last part of ModalDrawerReportPage) #4287

Merged
merged 68 commits into from
Oct 7, 2022
Merged

edit access measure details (last part of ModalDrawerReportPage) #4287

merged 68 commits into from
Oct 7, 2022

Conversation

braxex
Copy link
Contributor

@braxex braxex commented Oct 7, 2022

Description

Had to get the report drawer hydrating and saving data 👍

Resolves: https://qmacbis.atlassian.net/browse/MDCT-1981

How to test

  1. Go Section C: Access Measures and put it through its paces.
  2. Add, edit measure, enter details, edit details, delete, etc. Do it in different orders with multiple measures, mixing up between measures even. Everything should work great.

Changed Dependencies

n/a

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

braxex and others added 30 commits September 30, 2022 13:27
@braxex
unnest pages in report json
67f0a91
@braxex
refactor spreadsheet
ed1e5d0
@braxex
fix all types and prepare drawer and modal forms'
be63d7e
@braxex
final type tweaks
0c91cb3
@braxex
update copyAdminDisabledStatusToForms utility method
c73a5b4
@braxex
add more tests for utility methods
43ff3e4
@braxex
build add/edit modal; style initial page
40dff7f
@braxex
solve overwrite issue
747f3e9
@braxex
build out card with no functionality
662978d
@braxex
DynamicDrawerReportPage tests
da84664
@braxex
merge in main
b107923
@braxex
EntityDrawerReportPage → DrawerReportPage
4dd5fe0
@braxex
DynamicDrawerReportPage → ModalDrawerReportPage
48c11fb
@braxex
merge in naming changes
4e62a7d
@braxex
switch from record to entity
ba177ef
@braxex
change dynamicType to entityType
426412b
@braxex
fix failing test
de75390
@braxex
add AddEditEntityModal tests
313d91d
@braxex
add EntityCard tests
91ca4a1
@braxex
final styling and such"
7f40aff
@braxex
nick review feedback
7fec4fa
@braxex
Merge branch 'main' into dynamic-drawer-step-1
d81f865
Accessibility test fix
6a2b4f4
@braxex
hide text if no entities
d4e0ce2
Merge branch 'main' into dynamic-drawer-step-1
9290920
@braxex
wip
c03c841
@braxex
wip 2
74e1e68
@braxex
fix minor type error
f674c36
@braxex
Merge branch 'dynamic-drawer-step-1' into enter-access-measure-details
c4fb578
@braxex
wip
48eaa8c
scwambach
scwambach suggested changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@scwambach scwambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticing some funky behavior with the radio buttons. Seems like there might be some shared IDs

Screen.Recording.2022-10-07.at.11.28.39.AM.mov

@braxex
Copy link
Contributor Author

braxex commented Oct 7, 2022

@scwambach

Yeah this is something we've been seeing with ChoiceList fields every since we switched to them all having option# as their name. I need to make a bug ticket for it and get it in the backlog.

gmrabian
gmrabian approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scwambach
Copy link
Contributor

@braxex
gotcha, other than that, looks good! Should there be a spinner during the hydration?

Base automatically changed from enter-access-measure-details to main October 7, 2022 18:57
@braxex braxex merged commit 1a147a1 into main Oct 7, 2022
@braxex braxex deleted the edit-measure-details branch October 7, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmrabian gmrabian gmrabian approved these changes

@ntsummers1 ntsummers1 ntsummers1 approved these changes

@scwambach scwambach scwambach approved these changes

@karla-vm karla-vm Awaiting requested review from karla-vm karla-vm is a code owner

@TheDanMiller TheDanMiller Awaiting requested review from TheDanMiller

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@juliuscaesar juliuscaesar Awaiting requested review from juliuscaesar

@britt-mo britt-mo Awaiting requested review from britt-mo

Assignees

@braxex braxex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braxex @scwambach @ntsummers1 @gmrabian