Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCT-2009 add skipnav to sidebar #4315

Merged
merged 2 commits into from
Oct 11, 2022
Merged

MDCT-2009 add skipnav to sidebar #4315

merged 2 commits into from
Oct 11, 2022

Conversation

gmrabian
Copy link
Contributor

Description

MDCT-2009 Add skip option to the sidebar

How to test

  • Go to a report page
  • Tab to the sidebar and notice it prompts you about skipping it first
  • Skipping it takes you to the main content
  • Not skipping proceeds through the sidebar

The skip option is only visible when tabbed

Skipping from the header (first skip) goes directly to the sidebar (second skip) on report pages

Code author checklist

  • I have performed a self-review of my code
  • I have added thorough tests
  • I have added analytics, if necessary
  • I have updated the documentation, if necessary

Reviewer checklist (two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

Copy link
Contributor

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf

@gmrabian gmrabian merged commit 62e129a into main Oct 11, 2022
@gmrabian gmrabian deleted the sidebar-skip branch October 11, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants