-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
val → prod #4952
Merged
Merged
val → prod #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* timeout * add modal * add format() to get rid of warning * more tests passing * mock amplify in tests * globally mock hub in amplify * lifecycle test coverage * add timeout tests and cleanup * real values * serverless values werent added to my last commit * fix test names * fix test warnings * refactor timeouts * timeout refactoring * fixing unit tests * Simplify nested timeouts and better coverage * attempt to use same unit test script Co-authored-by: juliuscaesar <caesarnuzzolo@Coforma-WTWWRT94NR-Caesar-Nuzzolo.local> Co-authored-by: brendan <brendan@coforma.io> Co-authored-by: Garrett Rabian <garrett@coforma.io> Co-authored-by: Caesar Nuzzolo <3749120+juliuscaesar@users.noreply.github.com>
* Add Cucumber/Gherkin tests for creating a program * Swap to Gherkin/Cucumber for MCPAR Dashboard and Form * Finish up Form input * text fic * text fix * fix * fix * test fix * update from some PR review comments * Thomas Feedback Edits * Removed now old integration tests * Add to github action * Clean up after self in Sidebar E2E test * Fix variable usage in Accessibility tests * Remove added quotes for Accessibility examples * Swap quotes on get for sidebar call * Swap quotes on get for sidebar call * Remove before and aftereach hooks due to failing action * Attempt to define more clear creation of programs * Navigate to homepage added for sidebar * Comment out for quicker screenshot debug Co-authored-by: Nicholas Summers <nick@coforma.io> Co-authored-by: Britt <britt.bujacich@gmail.com> Co-authored-by: Garrett <57802560+gmrabian@users.noreply.github.com>
Co-authored-by: Nicholas Summers <nick@coforma.io>
Comment out program integration tests until we can get things set in place
* limit report call * lower limit and log * remove logs Co-authored-by: Nick Summers <ntsummers1@gmail.com> Co-authored-by: Garrett Rabian <garrett@coforma.io>
main → val
main → val
braxex
requested review from
karla-vm,
TheDanMiller,
BearHanded,
gmrabian,
ntsummers1,
juliuscaesar,
scwambach and
britt-mo
as code owners
December 6, 2022 15:12
juliuscaesar
approved these changes
Dec 6, 2022
🎉 |
scwambach
approved these changes
Dec 6, 2022
karla-vm
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
val → prod
Feature changes:
Testing changes: