Verify that the Postgres version is 17 or newer on incremental backups #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barthisrael
approved these changes
Jun 20, 2024
I do agree. Rebase, squash and merge @bleidens |
gcalacoci
approved these changes
Jun 20, 2024
|
@bleidens I can see you force pushed a few minutes ago, likely to add some changes from |
|
@barthisrael Yes, I just finished resolving the conflicts with the previous merge, I will now take a look at the new conflicts in |
Performing an incremental backup using Postgres mode requires the Postgres server's version to be 17 or newer. This PR builds from the validation methods introduced by BAR-160 (`validate_backup_args` and `_validate_incremental_backup_configs`), adding a check for the Postgres server's version and issue an error if it's not compatible with incremental backups (<17). References: BAR-163 Signed-off-by: Barbara Leidens <barbara.leidens@enterprisedb.com>
gcalacoci
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing an incremental backup using Postgres mode requires the Postgres server's version to be 17 or newer. This PR builds from the validation methods introduced by BAR-160 (
validate_backup_argsand_validate_incremental_backup_configs), adding a check for the Postgres server's version and issue an error if it's not compatible with incremental backups (<17).References: BAR-163