Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closing several old term request issues from Jagadish #1367

Closed
9 of 10 tasks
turbomam opened this issue Aug 18, 2022 · 7 comments · Fixed by #1391
Closed
9 of 10 tasks

closing several old term request issues from Jagadish #1367

turbomam opened this issue Aug 18, 2022 · 7 comments · Fixed by #1391
Assignees

Comments

@turbomam turbomam self-assigned this Aug 18, 2022
@turbomam
Copy link
Contributor Author

@pbuttigieg
Copy link
Member

Many thanks @turbomam

@turbomam
Copy link
Contributor Author

turbomam commented Aug 18, 2022

I don't see the following from NMDC-03_EnvO_template_robot_sheet

ontology ID label
ENVO:03600090 alcohol fermentation pit
ENVO:03600091 clay fermentation pit
ENVO:03600092 artificial pond
ENVO:03600093 artificial satellite

I do see

@turbomam turbomam changed the title closing old, individual term requests from Jagadish closing several old term request issues from Jagadish Aug 18, 2022
@turbomam
Copy link
Contributor Author

http://purl.obolibrary.org/obo/ENVO_03600039 (fermentation pit) does say

AnnotationAssertion(Annotation(http://www.geneontology.org/formats/oboInOwl#hasDbXref https://en.wikipedia.org/wiki/Baijiu) Annotation(http://www.geneontology.org/formats/oboInOwl#hasDbXref https://www.frontiersin.org/articles/10.3389/fmicb.2020.01223/full) http://purl.obolibrary.org/obo/IAO_0000115 http://purl.obolibrary.org/obo/ENVO_03600039 "A pit which has been constructed for use in fermentation processes that will yield alcoholic spirits."@en)

So maybe we can say that another 'alcohol fermentation pit' term doesn't need to be created, but I would like to add it as a (narrow?) synonym.

@turbomam
Copy link
Contributor Author

ontology ID label parent class definition definition cross reference comment comment cross reference editors note exact synonym broad synonym narrow synonym related synonym in subset cross reference subclass axiom creation date created by                  
ID AL rdfs:label@en SC % AL IAO:0000115@en >AI oboInOwl:hasDbXref SPLIT=| AL rdfs:comment@en >AI oboInOwl:hasDbXref SPLIT=| AL IAO:0000116@en AL oboInOwl:hasExactSynonym@en SPLIT=| AL oboInOwl:hasBroadSynonym@en SPLIT=| AL oboInOwl:hasNarrowSynonym@en SPLIT=| AL oboInOwl:hasRelatedSynonym@en SPLIT=| A oboInOwl:inSubset SPLIT=| AI oboInOwl:hasDbXref SPLIT=| SC % SPLIT=| AT oboInOwl:creation_date^^xsd:dateTime AI oboInOwl:created_by SPLIT=|                  
ENVO:03600092 artificial pond pond A pond which has been constructed by humans or their technologies.   Definition from 2021-08-05 call with But­ti­gieg, Duncan and Miller   add axioms to reason this under human construction               2021-08-09T15:00:00.000Z https://orcid.org/0000-0001-9076-6066|https://orcid.org/0000-0002-4366-3088|https://orcid.org/0000-0001-9625-1899                  
ENVO:03600093 artificial satellite human construction A human construction that has intentionally been placed into orbit. https://en.wikipedia.org/wiki/Satellite Not to be confused with a natural satellite like the earth's moon (https://en.wikipedia.org/wiki/Natural_satellite)                   2021-08-09T15:00:00.000Z https://orcid.org/0000-0001-9076-6066|https://orcid.org/0000-0002-4366-3088|https://orcid.org/0000-0001-9625-1899                  

@pbuttigieg
Copy link
Member

Please create a PR with your suggested additions and we'll close these lists. Thanks for detecting the omissions @turbomam

@pbuttigieg
Copy link
Member

On fermentation pit - I'd generalise that class' definition and add a subclass for alcoholic fermentation pits

turbomam added a commit that referenced this issue Dec 5, 2022
cmungall added a commit that referenced this issue Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants