Handle const addr casts #1752
Merged
Handle const addr casts #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwe
reviewed
Aug 25, 2024
test/runtests.jl
Outdated
| @@ -780,6 +780,38 @@ end | |||
| @test hess[1][2] ≈ 1.0 | |||
| @test hess[2][1] ≈ 1.0 | |||
| @test hess[2][2] ≈ 0.0 | |||
|
|
|||
| function f_ip(x, tmp) | |||
| tmp .= identity.(x) | |||
There was a problem hiding this comment.
Not sure you'll trigger the issue with identity, I think the broadcasting machinery specializes on that one to produce the same code as tmp .= x. That's why I used the custom g(x) = x---equally trivial logic, but without the specialized code path.
There was a problem hiding this comment.
Confirming that identity fails to trigger the issue on my end. If you don't want to define the extra function you can also replace with something like tmp .= x ./ 2.
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.