Jacobian returns one array #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YingboMa what's the most useful/common output of the jacobian function in the ecosystem? |
|
Ok now we are in agreement with ForwardDiff.jl |
wsmoses
reviewed
Jun 2, 2022
| @@ -780,6 +787,7 @@ end | |||
| adjoint(Duplicated(x, dx), tape) | |||
| return dx | |||
| end | |||
| mapreduce(LinearAlgebra.adjoint, vcat, rows) | |||
There was a problem hiding this comment.
Kind of hacky, but would it be possible to create the zero init'd matrix, then unsafe_array it at the corresponding offset for each index to avoid making a bunch of temporaries
There was a problem hiding this comment.
I will leave that for you as an optimization.
vchuravy
commented
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.