Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preprocessed funcs & fix typeof #440

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Remove preprocessed funcs & fix typeof #440

merged 1 commit into from
Sep 5, 2022

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Sep 5, 2022

No description provided.

vchuravy
vchuravy approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to Core.Typeof is sensible. Why do we need to remove the preprocessed function?

@wsmoses
Copy link
Member Author

wsmoses commented Sep 5, 2022

The preprocessed function itself can have a call which triggers #337
By removing it, any time that the error occurs, we can ensure it comes from the actual derivative code (as opposed to a auxillary data structure). Removing it actually caused the parameter test to compile!

Also, reducing the amount of code LLVM needs to post optimize in half is certainly a good thing for latency.

@wsmoses wsmoses merged commit fd50901 into main Sep 5, 2022
@wsmoses wsmoses deleted the PPFc branch September 5, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsmoses @vchuravy