[mlir] support unknown (top) state in aliasing and activity analysis #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengmai
approved these changes
Dec 7, 2023
ftynse
force-pushed
the
ftynse/unfixed
branch
from
fa5cc85
to
996d38b
Compare
- Update the points-to lattice to indicate that "other" pointers may have pointers to unknown location stored, but some specific pointers may have pointers to known locations. - Add a trivial may/must write differentiation. - The tests are *NOT* fully updated.
* some support is still missing in printers of activity analyses * three tests are failing because they produce different results now (haven't investigated if the previous expectations were correct)
* Fix points-to-pointer analysis to return "other" value, which may be empty set (lattice bottom) rather than always returning "any" (lattice top). * Don't get tricked by operator[] on maps default-initializing the value in `map[key] == deafult_value` comparison attempting to see if the map changed. * Propagate changes in two places. * Fix "other" in/out activity state in dense (pointer) activity analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add conservative handling of unknown situations in alias analysis.