Fix integration tests on main #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilesCranmer
added a commit
to MilesCranmer/Enzyme
that referenced
this pull request
Jul 24, 2024
Since DynamicExpressions.jl seems to be particularly good at finding issues with Enzyme, such as: - EnzymeAD#548 - EnzymeAD#552 - EnzymeAD#816 - EnzymeAD#999 - EnzymeAD#1009 - EnzymeAD#1018 - EnzymeAD#1156 - EnzymeAD#1662 - EnzymeAD#1674 This PR therefore adds a simple integration test for it so that such issues will get flagged immediately. The CI also pins DynamicExpressions to a specific version where it has been known to work, so any failures would indicate some kind of regression. Also, this is a separate CI run so won't be recorded in the main test suite. I restructured the CI so that packages can add their own integration tests fairly easily: ```yaml matrix: version: - '1' os: - ubuntu-latest test: - DynamicExpressions steps: - uses: actions/checkout@v4 - uses: julia-actions/setup-julia@v1 with: version: ${{ matrix.version }} - uses: julia-actions/cache@v1 - uses: julia-actions/julia-buildpkg@v1 - name: "Run tests" run: | julia --color=yes --project=. -e 'using Pkg; pkg"instantiate"' julia --color=yes --project=test/integration -e 'using Pkg; pkg"dev ."; pkg"instantiate"' julia --color=yes --project=test/integration --threads=auto --check-bounds=yes -e test/integration/${{ matrix.test }}.jl shell: bash ``` All they need to do is create a new `test/integration/{PackageName}.jl` file and add it to the list. @gdalle maybe you could rebase EnzymeAD#1563 on this so we can have them in the same format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.