Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests into two packages in Bazel build. #1741

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Split tests into two packages in Bazel build. #1741

merged 1 commit into from
Feb 20, 2024

Conversation

ftynse
Copy link
Collaborator

@ftynse ftynse commented Feb 19, 2024

This separates MLIR tests and regular Enzyme integration tests into independent packages, making sure only a subset of targets is rebuilt and retested when requested to decrease overhead.

@wsmoses
Copy link
Member

wsmoses commented Feb 19, 2024

ERROR: no such package 'third_party/enzyme': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /home/runner/work/Enzyme/Enzyme/enzyme/third_party/enzyme
ERROR: /home/runner/work/Enzyme/Enzyme/enzyme/test/Integration/BUILD:8:13: every rule of type py_test implicitly depends upon the target '//third_party/enzyme:license', but this target could not be found because of: no such package 'third_party/enzyme': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /home/runner/work/Enzyme/Enzyme/enzyme/third_party/enzyme
Analyzing: [18](https://github.com/EnzymeAD/Enzyme/actions/runs/7962983772/job/21737646771?pr=1741#step:6:19)3 targets (73 packages loaded, 788 targets configured)
[2 / 2] checking cached actions
Analyzing: 183 targets (73 packages loaded, 788 targets configured)
[2 / 2] checking cached actions
Target //test:lit_site_cfg_py up-to-date:
  bazel-bin/test/lit.site.cfg.py
ERROR: Analysis of target '//test/Integration:ReverseMode/taylorlog.c.test' failed; build aborted: Analysis failed
INFO: Elapsed time: 7.078s, Critical Path: 0.01s
INFO: 2 processes: 2 internal.
ERROR: Build did NOT complete successfully
ERROR: No test targets were found, yet testing was requested

This separates MLIR tests and regular Enzyme integration tests into independent
packages, making sure only a subset of targets is rebuilt and retested when
requested to decrease overhead.
@ftynse ftynse marked this pull request as ready for review February 20, 2024 14:52
@ftynse ftynse added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit e8ca2b1 Feb 20, 2024
46 of 54 checks passed
@ftynse ftynse deleted the split-bazel branch February 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants