-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clicking through search results fails #6
Comments
Hi did you see any facets here? |
I did see facets, but it may be because I had run the indexing first. Tom Elliott, Ph.D. On Wed, Nov 18, 2015 at 10:05 AM, emmamorlock notifications@github.com
|
Sounds coherent. How do you do that? |
After following steps 1-4 here I clicked on "admin" and then clicked the "index all (search)" button. |
Thanks! hadn't seen the admin entry. |
Just to clarify: you are able to click through the search results list to a single file without errors? |
The issue is that the indexing (specifically in stylesheets/solr/tei-to-solr-common.xsl) uses publicatonStmt/idno[@type="filename"] as the tei-id, which doesn't work well when that is not, in fact, the filename. Either the markup is wrong, or the filenames need to be changed to match the data, or another ID is added to the XML that does match the filename. |
it seems to me that its another pb: the fool path to the resource is not served. |
Il meant full path |
The URL for a search result is generated using the information stored in the search index for the filename. This information needs to be the path and filename (relative to the content/xml/tei directory) of the file that was the source of the indexed data, as you say. The indexing needs to be changed, either to take the path and filename from the filesystem, or to get that information from somewhere else in the XML. If the XML as it stands is deemed correct, then the former solution should be implemented. The display of the title is a separate issue. |
Yes, it's a combination of both things. When putting the example files in place, I changed the filenames to make them more reliably unique (i.e. containing collection name as well as internal id), but forgot to change the idno[type=filename]. However, the search index also needs the path to the correct folder, which may be (a) "samples", (b) "inscriptions", or (c) a sub-directory of "inscriptions" for projects with nested file structure. |
I fixed the first issue (incorrect idno[type=filename]) and pushed them to the repo. The other part is search code that I haven't delved into, however. |
I'm about to commit a fix for this. Unfortunately it tramples on the multilingual element a little, but the alternatives are a poorer fix or refactoring a bunch of other stuff. The latter can be done later. After updating the code, delete the data in webapps/solr/data/index, start Kiln, and perform a reindex. |
Clone and install EFES following instructions at http://kiln.readthedocs.org/en/latest/quickstart.html
Mac OSX 10.11.1
/search
Result:
Stacktrace:
The text was updated successfully, but these errors were encountered: