Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_prior_string misses some attributes of the dimension #774

Closed
Delaunay opened this issue Feb 1, 2022 · 0 comments
Closed

get_prior_string misses some attributes of the dimension #774

Delaunay opened this issue Feb 1, 2022 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@Delaunay
Copy link
Collaborator

Delaunay commented Feb 1, 2022

assert builder.build(configure).configuration == configure

  • Precision is omitted

    • AssertionError: assert ('a2', 'uniform(0, 1)') == ('a2', 'unifo...precision=2)')
  • normal becomes norm

    • AssertionError: assert ('c0', 'norm(0, 1)') == ('c0', 'normal(0, 1)')
  • base inside fidelity is behaving weird

    • AssertionError: assert ('e0', 'fidelity(10, 100, 2)') == ('e0', 'fidelity(10, 100)')
    • AssertionError: assert ('e1', 'fidelity(10, 100, 3)') == ('e1', 'fidel...100, base=3)')
@Delaunay Delaunay added the bug Indicates an unexpected problem or unintended behavior label Feb 1, 2022
@bouthilx bouthilx changed the title get_prior_string does not include precision get_prior_string misses some attributes of the dimension Feb 1, 2022
Delaunay added a commit that referenced this issue Feb 4, 2022
@Delaunay Delaunay closed this as completed Feb 4, 2022
lebrice pushed a commit to lebrice/orion that referenced this issue Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant