-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assert_contains to print a more precise error message #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
reviewed
Nov 1, 2022
bouthilx
reviewed
Nov 1, 2022
bouthilx
reviewed
Nov 1, 2022
Delaunay
force-pushed
the
deprecation_fix
branch
from
November 1, 2022 16:06
488278b
to
5a53920
Compare
Delaunay
force-pushed
the
deprecation_fix
branch
from
November 29, 2022 17:09
a873046
to
a041b20
Compare
bouthilx
reviewed
Nov 30, 2022
bouthilx
reviewed
Nov 30, 2022
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
Delaunay
force-pushed
the
deprecation_fix
branch
from
December 5, 2022 19:36
ad8af32
to
503a9a4
Compare
bouthilx
reviewed
Dec 6, 2022
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
bouthilx
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bouthilx
changed the title
Deprecation fix
Add assert_contains to print a more precise error message
Dec 16, 2022
bouthilx
added
the
enhancement
Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
label
Dec 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to np.object which is deprecated