Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing experiment.algorithms to experiment.algorithm #1014

Merged
merged 31 commits into from
Jan 20, 2023
Merged

Changing experiment.algorithms to experiment.algorithm #1014

merged 31 commits into from
Jan 20, 2023

Conversation

Simnol22
Copy link
Contributor

Description

We are changing experiment.algorithms to experiment.algorithm, since it makes more sense. This solves the issue 730._

Changes

changing all the experiment.algorithms to experiment.algorithm.

Tests

  • [ x] I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • [x ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • [x ] I have updated the relevant documentation related to my changes

Quality

  • [ x] I have read the CONTRIBUTING doc
  • [ x] My commits messages follow this format
  • [ x] My code follows the style guidelines ($ tox -e lint)

@bouthilx
Copy link
Member

Needs rebase

bouthilx
bouthilx approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bouthilx
Copy link
Member

Please wait for tests to pass before merge.

@Simnol22 @Simnol
changing experiment.algorithms to experiment.algorithm
4a28e72
@Simnol22 @Simnol
fixing building_experiment
9c35349
@Simnol22 @Simnol
changing some more algorithms to algorithm
4c06127
@Simnol22 @Simnol
fixing experiments variable name forgotten
570c473
@Simnol22 @Simnol
sending algorithms in benchmark creation of experiment
7ed6656
@Simnol22 @Simnol
changing algorithms in config files for tests
be454f7
@Simnol22 @Simnol
change algorithm_name for experiment in benchmark
393fddd
@Simnol22 @Simnol
exp.configuration had algorithms keys
3774087
@Simnol22 @Simnol
study test with algorithms
2b9a4cd
@Simnol22 @Simnol
add warning and make algorithms still work but deprecated
3650b04
@Simnol22 @Simnol
Add backward compatibility
663a759
@Simnol22 @Simnol
disable too-many-locals for pylint
666258c
@Simnol22 @Simnol
fixing line too long
475d591
@Simnol22 @Simnol
stop sending None algorithm when there isnt one
4c28046
@Simnol22 @Simnol
adding algorithms to test
8813654
@Simnol22 @Simnol
backward python_api algorithms
6a1c8ad
@Simnol22 @Simnol
Fixing upgrade for algorithms
c51233f
@Simnol22 @Simnol
Adding check for setting algorithm or algorithms to None
b3b44fd
@Simnol22 @Simnol
setting up instantiated_algorithms if both algorithms are None
435eb9a
@Simnol22 @Simnol
sending only algorithm to Experiment
891d48d
@Simnol22 @Simnol
instanciated algorithms cannot be None by default
7193357
@Simnol22 @Simnol
fixing comment, restarting pipeline
edfd652
@Simnol22 @Simnol
changing algorithms in docs
c5c0f89
@bouthilx bouthilx mentioned this pull request Jan 19, 2023
Merged
@bouthilx bouthilx merged commit 47a83fa into Epistimio:develop Jan 20, 2023
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simnol22 @bouthilx @Simnol