Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding HuggingFace Tutorial #1040

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Adding HuggingFace Tutorial #1040

merged 9 commits into from
Jan 17, 2023

Conversation

Simnol22
Copy link
Contributor

@Simnol22 Simnol22 commented Dec 9, 2022

Description

Writing a tutorial on how to use Orion with a HuggingFace model, including the use of the hydra_orion_sweeper, Comet and custom Callbacks.

Changes

Simply adding files in the docs and examples foldders.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • [x ] I have updated the relevant documentation related to my changes

Quality

  • [ x] I have read the CONTRIBUTING doc
  • [ x] My commits messages follow this format
  • [ x] My code follows the style guidelines ($ tox -e lint)

lebrice
lebrice reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@lebrice lebrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(just corrected a few typos)

docs/src/tutorials/huggingface.rst Outdated Show resolved Hide resolved
docs/src/tutorials/huggingface.rst Outdated Show resolved Hide resolved
docs/src/tutorials/huggingface.rst Outdated Show resolved Hide resolved
docs/src/tutorials/huggingface.rst Outdated Show resolved Hide resolved
examples/huggingface/main.py Outdated Show resolved Hide resolved
examples/huggingface/main.py Outdated Show resolved Hide resolved
@lebrice lebrice changed the title Adding HugginFace Tutorial Adding HuggingFace Tutorial Jan 13, 2023
bouthilx
bouthilx approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot! :)

@bouthilx bouthilx merged commit d75c254 into Epistimio:develop Jan 17, 2023
@bouthilx bouthilx mentioned this pull request Jan 17, 2023
Open
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebrice lebrice lebrice left review comments

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simnol22 @bouthilx @lebrice