Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks from Profet #632

Merged
merged 135 commits into from
Mar 9, 2022
Merged

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Aug 3, 2021

This is a draft, I will update this description in the future.

Description

  • Adds tasks from OpenML (Removed, will tackle this in another PR)
  • Adds tasks from Profet

TODOs

  • De-couple everything out of the warmstart repo
  • Add external dependency for simple_parsing
  • Add a new extras_require for profet
    • Add checks so that the profet tasks are truly optional (things dont crash if the profet extras aren't installed, tests are skipped properly. **I'd actually need some help with this @bouthilx **
    • Test that all the required packages are correctly listed (e.g. by creating a blank new conda env and then running tests)
  • Update the profet benchmark example script
  • Tests for Profet tasks (Add tasks from Profet #632 (comment))
    • Arguments
      • benchmark
      • max_trials
      • task_id
      • seed
      • input_dir
      • checkpoint_dir
      • train_config. This one would require to mock the model trained and some functions used to train it to verify that the training config is passed down the call stack properly. No need to test all the way down, only at end of stack is fine (deepest function called where the config is actually used).
      • device
    • Behaviors
      • Testing the checkpoint based on hash. No clash, unique and reproducible.
      • self.name. Should it contain something else than task_id? Hash maybe?
      • Test seeding (test_call_is_reproducible)
      • Re-using checkpoint (test_instantiating_task)
      • configuration (test_configuration)
      • With gradients (test_with_gradients)
  • Add documentation? docstrings everywhere :)
    - [ ] Tests for Quadratics task
    - [ ] Same basic tests as other tasks
    - [ ] Test with_context (Add tasks from Profet #632 (comment))

Discussions not resolved yet:

lebrice and others added 28 commits February 1, 2022 14:36
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
- Revert the previous change to BenchmarkTask.__call__, making it
  possible to pass some positional arguments again. I believe this is
  simpler and cleaner than updating the tests and examples everywhere.

Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through all this work to add Profet!

@lebrice lebrice merged commit 298f91d into Epistimio:develop Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants