Fix ASHA for identical objectives #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The sorting of trials during promotion was not only looking at objectives, but also at trials. Problem is, trials are not comparable. This bug was not detected because during tests trials always have a different objective, hence the comparisons would always stop at the objective when comparing the tuples (objective, trial). How: Add tests with identical objectives, and use objective only for sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The sorting of trials during promotion was not only looking at
objectives, but also at trials. Problem is, trials are not comparable.
This bug was not detected because during tests trials always have a
different objective, hence the comparisons would always stop at the
objective when comparing the tuples (objective, trial).
How:
Add tests with identical objectives, and use objective only for sorting.