Test algo can handle broken trials #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the trial is broken it should be considered as such by the algorithm, it is not pending anymore. algo.has_observed(broken_trial) should return True.
lebrice
reviewed
Mar 2, 2022
| and self._trials_info[self.get_id(trial)][1] is not None | ||
| if not self.has_suggested(trial): | ||
| return False | ||
| return self._trials_info[self.get_id(trial)][0].status in ( |
There was a problem hiding this comment.
Why does this check only the first index? Is it always a len(1) sequence? If there were to be duplicates, should this do anything different?
There was a problem hiding this comment.
It's a bad design. I'd like to address this with a more formal in-memory storage for algorithms are shortly described here: #802.
The format is
self._trials_info[some_trial_id] = (trial_object, trial_objective)Previously we only looked at the objective at index 1, now we only look at the trial at index 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the trial is broken it should be considered as such by the
algorithm, it is not pending anymore.
algo.has_observed(broken_trial) should return True.