-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hebo #915
Conversation
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
LGTM. There may be 2 comments worth creating issues, the other one is only a minor fix. |
If you move the hebo tests to the |
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
HEBO tests take a significant amount of time to run, so it should be moved in long folder and run in the test-long matrix as pointed out by @Delaunay . |
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@bouthilx agreed! I moved the tests to the "long" folder, which I then renamed to "extras". (I also adjusted the workflow names to reflect this). This seems good to go on my end. Lmk if you have any comments (@Delaunay as well). |
Oops, I forgot to increase the max parallel jobs value (as suggested by @Delaunay ) I'll do that now |
I disagree. The number of algorithms will continue growing and this will increase significantly the number of jobs. I believe we should try to reduce the number of jobs, and the criterion to do so is whether the algorithm takes to much time to run sequentially or not. |
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Migration of the HEBO algorithm from a plugin repo on GitHub into the Orion repo.