add github linter #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
force-pushed
the
lr/test/add-gh-lint
branch
from
061e69e
to
8a2bf21
Compare
|
Nope, as long as this works I am ok with it |
leoromanovsky
pushed a commit
that referenced
this pull request
Aug 26, 2022
# This is the 1st commit message: Client + client tests + refactoring # This is the commit message #2: fix null pointer; fix panic test # This is the commit message #3: Refactor factory methods # This is the commit message #4: Refactor factory method for the configuration store # This is the commit message #5: Refactor factory method for the configuration requestor # This is the commit message #6: Refactor factory method for the EppoClient # This is the commit message #7: Fix for EppoClient tests # This is the commit message #8: Add testify lib + use asserts pt.1 # This is the commit message #9: Use asserts pt.2 # This is the commit message #10: Slight refactor # This is the commit message #11: Remove resty client in favor of httpClient # This is the commit message #12: Add mocks # This is the commit message #13: Add EppoClient test for assignment log # This is the commit message #14: Add test for logging panic # This is the commit message #15: Add EppoClient test for subject with attributes and rules # This is the commit message #16: Add functionality + test for overrides # This is the commit message #17: Add remaining tests # This is the commit message #18: Remove not required commented code # This is the commit message #19: remove not required test # This is the commit message #20: add unit test makefile and github action to build and test # This is the commit message #21: add github linter (#5) * add github linter; downgrade to go 1.18 to support it * enable all linters * delete config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds https://github.com/golangci/golangci-lint-action
I found that the tool is not stable on golang 1.19; downgrading to 1.18 got it to work well. I'm sure 1.19 will be supported soon but it was recently released (https://go.dev/blog/go1.19). Anything in 1.19 you feel is a must have?