feat: Bandits part 5: load and store bandit models from API #28
+310
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
commented
Jul 16, 2024
| @@ -36,7 +45,7 @@ public function getFlag(string $key): ?Flag | |||
| return null; | |||
| } | |||
|
|
|||
| $inflated = unserialize($result); | |||
| $inflated = $result; | |||
There was a problem hiding this comment.
underlying cache layer is already doing the serializing... 🤦
|
Thanks for the review! |
aarsilv
approved these changes
Jul 17, 2024
| */ | ||
| private function fetchAndStoreBandits(): void | ||
| { | ||
| // TODO: implement optimized fetching by checking for expected bandit models from UFC response. |
Comment on lines
+120
to
+121
| // Only load bandits if there are any referenced by the flags. | ||
| if ($indexer->hasBandits()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The bandit model data is retrieved from an endpoint different than that used to load the rest of the UFC flag configuration data. Again, similar to previous PRs, we see refactoring in order to leverage existing codepaths for different data types
Description
APIRequestWrapperclass to load from a second endpointHow is this tested