add checkin api, test included #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Guo
reviewed
Feb 28, 2019
| @@ -24,6 +24,15 @@ def agent(agentid) | |||
| get 'agent/get', params: { agentid: agentid } | |||
| end | |||
|
|
|||
| def checkin(useridlist, starttime = Time.now.beginning_of_day, endtime = Time.now.end_of_day, opencheckindatatype = 3) | |||
| post 'checkin/getcheckindata', JSON.generate( | |||
| useridlist: useridlist, | |||
There was a problem hiding this comment.
Still better put useridlist at end of hash, maybe not relevant, but still better just following the document sequence.
There was a problem hiding this comment.
Normally we need to fetch checkin data of the current day, thus
starttime and endtime will be mostly default as the beginning of the current day and the end of the current day. opencheckindatatype will be mostly equal to 3, which means fetching the whole list. The only changing argument at the most time is useridlist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
加入获取打卡数据的的API: https://work.weixin.qq.com/api/doc#11196
Test included, all tests passed.