Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPSock.cpp - Changes to several Port Listening and Binding errormessa… #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarcoPolo-development
Copy link

…ges.

Rewritten several Listening and Binding errormessages, aswell as comment @line 435. Documentation.dat will be added to the main branch and contain comments that refer to Work in future for a better overview. This file can be used for any kind of useful documentation ofcourse.

"Socket initialization failed!" @line 83
"Binding failed" @line 94
"WSAAsyncSelect failed!" @line 107
"Socket initialization failed!" @line 144
"Binding failed!" @line 191
"Single socket initialization failed!" @line 219
"Single binding failed!" @line 266

…ges.

Rewritten several Listening and Binding errormessages, aswell as comment @line 435. Documentation.dat will be added to the main branch and contain comments that refer to Work in future for a better overview. This file can be used for any kind of useful documentation ofcourse. 

"Socket initialization failed!" @line 83 
"Binding failed" @line 94
"WSAAsyncSelect failed!" @line 107
"Socket initialization failed!" @line 144 
"Binding failed!" @line 191 
"Single socket initialization failed!" @line 219 
"Single binding failed!" @line 266
Translated the README.md to english.
@kevinkouketsu
Copy link
Collaborator

I will create a new issue regarding these error messages.
But I appreciate your changes!

@kevinkouketsu kevinkouketsu requested review from EricSantos00 and kevinkouketsu and removed request for EricSantos00 August 1, 2022 21:56
@kevinkouketsu kevinkouketsu added the documentation Improvements or additions to documentation label Aug 1, 2022
@MarcoPolo-development
Copy link
Author

I will create a new issue regarding these error messages. But I appreciate your changes!

Thanks for your reply! The issue #15 you created makes sense for sure. As loading data files already happen centralized, error output could need a smart overhaul aswell as you stated in the issue. I could def. look into this and come up with an example. As you requested further discussion first, I will see if a special concept is forming that should be followed.

Is creating a pull request like this one the right way for future commits?

Thanks for your reply again, hope I can be a help to this project. I actually know how scarse work on WYD Projects are.

@kevinkouketsu
Copy link
Collaborator

kevinkouketsu commented Aug 3, 2022

Yes, it is the correct way.

I just want to ask you that if you are going to create more than one pull request, you must separate the pull request concerns (with branches) and not mix everything in a single pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants