Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive artifacts before upload #561

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

andocz
Copy link
Contributor

@andocz andocz commented Mar 2, 2022

Closes #535.

This reduces the time the artifact upload takes from ~20-30 minutes to ~40 seconds. Compare https://github.com/Ericsson/CodeCompass/actions/runs/1886786933 and https://github.com/andocz/CodeCompass/actions/runs/1919240367.

A consequence of this change is that each artifact is now a zip file containing a zip file when downloaded. This is a limitation of how downloading artifacts from GitHub works, so there's no way around it. The contents of each inner zip remains the same, though.

@intjftw intjftw requested review from intjftw and mcserep March 4, 2022 10:04
@intjftw intjftw added Kind: Enhancement 🌟 Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI. labels Mar 4, 2022
@intjftw intjftw added this to the Release Gershwin milestone Mar 4, 2022
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@intjftw intjftw merged commit 959f63f into Ericsson:master Mar 4, 2022
@andocz andocz deleted the archive-before-upload branch March 7, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Enhancement 🌟 Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub artifact upload is slow
3 participants