Cpp metrics plugin #638
Merged
Cpp metrics plugin #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intjftw
added
Kind: Enhancement 🌟
Status: WIP 👷
mcserep
requested changes
Oct 3, 2023
mcserep
reviewed
Oct 3, 2023
mcserep
reviewed
Oct 3, 2023
mcserep
reviewed
Oct 3, 2023
plugins/cpp_metrics/parser/include/cppmetricsparser/cppmetricsparser.h
Outdated
Show resolved
Hide resolved
mcserep
reviewed
Oct 3, 2023
intjftw
removed
the
Status: WIP 👷
mcserep
added
Plugin: C++
mcserep
approved these changes
Oct 4, 2023
mcserep
requested changes
Oct 8, 2023
|
Incremental parsing should be supported by the new plugin as well.
Possible solutions:
|
mcserep
reviewed
Oct 18, 2023
mcserep
reviewed
Oct 18, 2023
mcserep
reviewed
Oct 18, 2023
mcserep
reviewed
Nov 8, 2023
Comment on lines
+66
to
+82
| for (const auto& pair : _astNodeIdCache) | ||
| { | ||
| auto file = _ctx.db->query_one<model::File>( | ||
| odb::query<model::File>::id == pair.second); | ||
|
|
||
| auto it = _ctx.fileStatus.find(file->path); | ||
| if (it != _ctx.fileStatus.end() && | ||
| (it->second == cc::parser::IncrementalStatus::DELETED || | ||
| it->second == cc::parser::IncrementalStatus::MODIFIED || | ||
| it->second == cc::parser::IncrementalStatus::ACTION_CHANGED)) | ||
| { | ||
| LOG(info) << "[cxxmetricsparser] Database cleanup: " << file->path; | ||
|
|
||
| _ctx.db->erase_query<model::CppAstNodeMetrics>(odb::query<model::CppAstNodeMetrics>::astNodeId == pair.first); | ||
| _astNodeIdCache.erase(pair.first); | ||
| } | ||
| } |
There was a problem hiding this comment.
In the loop above you are already iterating through all files and purging the ones, which has deleted, modified or action changed status. There is no need for another loop or for the _astNodeIdCache at all, we could simply purge the AST nodes there as well.
There was a problem hiding this comment.
I will accept it like this, so we can merge this, and created #670.
mcserep
approved these changes
Nov 8, 2023
wbqpk3
pushed a commit
to wbqpk3/CodeCompass
that referenced
this pull request
Jul 8, 2024
Co-authored-by: Máté Cserép <mcserep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the basis of the C++ metrics plugin. It contains the usual components of a plugin, including the fundamental db tables to store module-level and AST node-level (function, class) metrics. This plugin is intended to help Software Technology lab students start their projects.