Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Typo in thrift package name in requirement file #3394

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[fix] Typo in thrift package name in requirement file #3394

merged 1 commit into from
Aug 10, 2021

Conversation

csordasmarton
Copy link
Contributor

@csordasmarton csordasmarton commented Aug 10, 2021 •
edited
Loading

Closes #3393

@csordasmarton csordasmarton added this to the release 6.17.0 milestone Aug 10, 2021
whisperity
whisperity approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw damn. Sorry!

@whisperity whisperity added dependencies 📦 Pull requests that update a dependency file and removed config ⚙️ labels Aug 10, 2021
@csordasmarton csordasmarton merged commit 7fef107 into Ericsson:master Aug 10, 2021
@csordasmarton csordasmarton deleted the fix_thrift_typo_in_requirements branch January 28, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whisperity whisperity whisperity approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
bugfix 🔨 dependencies 📦 Pull requests that update a dependency file
Projects
None yet
Milestone
release 6.17.0
Development

Successfully merging this pull request may close these issues.

it should be thrift==0.13.0 rather than thirft==0.13.0
2 participants
@csordasmarton @whisperity