[gui] Fix for filter product in gui test #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
previously requested changes
Nov 3, 2021
| @@ -210,7 +211,8 @@ module.exports = { | |||
| searchInput: ".v-toolbar__content input[type='text']", | |||
| progressBar: ".v-data-table__progress", | |||
| editBtn: "tr .edit-btn", | |||
| removeBtn: "tr .remove-btn" | |||
| removeBtn: "tr .remove-btn", | |||
| overlayScrim: "div .v-overlay__scrim" | |||
There was a problem hiding this comment.
When you open a vuetify dialog window it will create two separate elements in the application root element:
v-overlayv-dialog
When you close a dialog, both of them will be dissapeared.
You class v-overlay__scrim is the child of the v-overlay element, and the v-overlay is connected to a v-dialog element.
So instead of this we have to find out which dialog is still in the DOM and have to wait for it while it is dissapeared instead of relying on an inner representation of a component.
vodorok
force-pushed
the
gui_test_fix
branch
2 times, most recently
from
8f53905
to
60c98f1
Compare
Wait until the div with class v-overlay__srim disappears from the font of the search bar.
vodorok
force-pushed
the
gui_test_fix
branch
from
60c98f1
to
8cba62e
Compare
bruntib
approved these changes
Dec 8, 2022
bruntib
dismissed
csordasmarton’s stale review
Patch has been fixed according to the review reqest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until the div with class v-overlay__srim disappears from the font
of the search bar.
Should fix #3435