Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfg] Assign new check profiles for 6.22RC1 #3861

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

gamesh411
Copy link
Collaborator

No description provided.

config/labels/analyzers/clang-tidy.json Outdated Show resolved Hide resolved
@@ -4798,6 +4847,12 @@
"profile:extreme",
"severity:LOW"
],
"cppcoreguidelines-rvalue-reference-param-not-moved": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in "default" profile?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in the default profile, because if only parts of the object are moved but not the whole object, then by default, the checker would warn. I don't have results to support my claim, but I think this could lead to annoying warnings.

I would leave this out of the default profile for now.

config/labels/analyzers/clang-tidy.json Show resolved Hide resolved
"profile:sensitive",
"severity:LOW"
],
"cppcoreguidelines-avoid-capturing-lambda-coroutines": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use "high" severity if it causes runtime error. Does this checker indicate a runtime error? Maybe "default" profile?

Copy link
Collaborator Author

@gamesh411 gamesh411 Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can indeed directly lead to UB, so I would keep the HIGH severity.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it to the default profile.

Endre Fulop added 2 commits March 23, 2023 18:42
- llvmlibc-inline-function-decl has STYLE instead of LOW severity
- cppcoreguidelines-avoid-reference-coroutine-parameters is now in
  default profile
- cppcoreguidelines-avoid-capturing-lambda-coroutines is now in default
  profile
@whisperity whisperity added analyzer 📈 Related to the analyze commands (analysis driver) config ⚙️ labels Mar 23, 2023
@bruntib bruntib merged commit 0c59a4f into Ericsson:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) config ⚙️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants