-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cfg] Assign new check profiles for 6.22RC1 #3861
Conversation
f6712d8
to
cbc7a77
Compare
@@ -4798,6 +4847,12 @@ | |||
"profile:extreme", | |||
"severity:LOW" | |||
], | |||
"cppcoreguidelines-rvalue-reference-param-not-moved": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in "default" profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be in the default profile, because if only parts of the object are moved but not the whole object, then by default, the checker would warn. I don't have results to support my claim, but I think this could lead to annoying warnings.
I would leave this out of the default profile for now.
"profile:sensitive", | ||
"severity:LOW" | ||
], | ||
"cppcoreguidelines-avoid-capturing-lambda-coroutines": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use "high" severity if it causes runtime error. Does this checker indicate a runtime error? Maybe "default" profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can indeed directly lead to UB, so I would keep the HIGH severity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added it to the default profile.
- llvmlibc-inline-function-decl has STYLE instead of LOW severity - cppcoreguidelines-avoid-reference-coroutine-parameters is now in default profile
- cppcoreguidelines-avoid-capturing-lambda-coroutines is now in default profile
No description provided.