[analyzer] Add a new flag to demote missing checker errors to a warning #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
added
CLI 💻
Szelethus
force-pushed
the
demote_err_to_warn_flag_for_missing_check
branch
from
21da47a
to
16d8425
Compare
vodorok
requested changes
Apr 11, 2023
| action='store_true', | ||
| required=False, | ||
| default=argparse.SUPPRESS, | ||
| help="Emit a warning instead of an error when " |
There was a problem hiding this comment.
Maybe include the recommendation from the commit message here too, that it is not advised to use this feature.
| LOG.warning(diag_msg) | ||
| else: | ||
| LOG.error(diag_msg) | ||
| LOG.info("If you want to suppress errors relating to unknown " |
There was a problem hiding this comment.
Maybe include the recommendation from the commit message here too, that it is not advised to use this feature.
There was a problem hiding this comment.
I've considered this, and it usually is my jam to shove my will down on anyones throat, but I figured that any one person that switches an error to a warning must know what they are doing.
bruntib
reviewed
Apr 12, 2023
Szelethus
force-pushed
the
demote_err_to_warn_flag_for_missing_check
branch
from
16d8425
to
6fa0e55
Compare
bruntib
approved these changes
Apr 13, 2023
| @@ -1065,7 +1101,7 @@ def test_analyzer_and_checker_config(self): | |||
| cwd=self.test_dir, | |||
| encoding="utf-8", | |||
| errors="ignore") | |||
| out, _ = process.communicate() | |||
| out, err = process.communicate() | |||
There was a problem hiding this comment.
Suggested change
| out, err = process.communicate() | |
| out, _ = process.communicate() |
PyLint is complaining about this unused variable, otherwise it looks good.
Szelethus
force-pushed
the
demote_err_to_warn_flag_for_missing_check
branch
from
6fa0e55
to
58e84b7
Compare
Altough discouraged, if someone really insists on having a soft warning when a checker is supplied to --enable or --disable, they can use the new flag '--no-missing-checker-error', which is disabled by default.
Szelethus
force-pushed
the
demote_err_to_warn_flag_for_missing_check
branch
from
58e84b7
to
7ce90c6
Compare
Szelethus
added a commit
to Szelethus/codechecker
that referenced
this pull request
Apr 15, 2024
…ecker-error 'CodeChecker analyze' was correctly turning errors into warnings when invoked with --no-missing-checker-error, but 'CodeChecker check' wasn't.
Szelethus
added a commit
to Szelethus/codechecker
that referenced
this pull request
Apr 15, 2024
…ecker-error 'CodeChecker analyze' was correctly turning errors into warnings when invoked with --no-missing-checker-error, but 'CodeChecker check' wasn't.
bruntib
added a commit
that referenced
this pull request
Apr 23, 2024
…ng_chk Fix a bug in #3866 where check didn't respect --no-missing-checker-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altough discouraged, if someone really insists on having a soft warning when a checker is supplied to --enable or --disable, they can use the new flag '--no-missing-checker-error', which is disabled by default.