Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cassandra 4.1 #217

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Support Cassandra 4.1 #217

merged 6 commits into from
Jun 12, 2023

Conversation

tommystendahl
Copy link
Collaborator

Closes #211

@@ -71,6 +67,9 @@

private static final String DEFAULT_SUPERUSER_NAME = "cassandra";

// Step the schema version if schema is updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange formatting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pom.xml Outdated Show resolved Hide resolved
loadFunction,
Collections::emptyMap, //Consider creating bilk loader
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider as in "TODO", "FIX"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After investigating how the AuthCache is used in ecAudit and how the bulkloader could be used I don't think a bulkloader will work here.

static private IAuthorizer authorizerMock = mock(IAuthorizer.class);
static private INetworkAuthorizer networkAuthorizerMock = mock(INetworkAuthorizer.class);

private ClientInitializer()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #217 (d1c6547) into master (531d45f) will increase coverage by 1.04%.
The diff coverage is 42.85%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     70.05%   71.09%   +1.04%     
+ Complexity      715      710       -5     
============================================
  Files            77       76       -1     
  Lines          2441     2391      -50     
  Branches        193      185       -8     
============================================
- Hits           1710     1700      -10     
+ Misses          702      662      -40     
  Partials         29       29              
Flag Coverage Δ
unit-tests 71.09% <42.85%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cassandra/ecaudit/auth/AuditWhitelistManager.java 96.15% <ø> (-0.68%) ⬇️
.../bss/cassandra/ecaudit/auth/WhitelistContract.java 100.00% <ø> (ø)
...ss/cassandra/ecaudit/auth/WhitelistDataAccess.java 19.75% <0.00%> (+5.33%) ⬆️
.../cassandra/ecaudit/auth/WhitelistOptionParser.java 100.00% <ø> (ø)
...caudit/entry/factory/AuditEntryBuilderFactory.java 3.56% <0.00%> (ø)
.../bss/cassandra/ecaudit/config/AuditYamlConfig.java 84.09% <20.00%> (-8.22%) ⬇️
...sson/bss/cassandra/ecaudit/config/AuditConfig.java 88.09% <40.00%> (-6.50%) ⬇️
...on/bss/cassandra/ecaudit/auth/AuditAuthorizer.java 89.28% <100.00%> (-0.72%) ⬇️
...bss/cassandra/ecaudit/auth/WhitelistOperation.java 100.00% <100.00%> (ø)
...ndra/ecaudit/filter/role/RoleAuditFilterCache.java 100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@masokol masokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed some comments

@tommystendahl tommystendahl merged commit 7a21999 into Ericsson:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants