-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Cassandra 4.1 #217
Conversation
@@ -71,6 +67,9 @@ | |||
|
|||
private static final String DEFAULT_SUPERUSER_NAME = "cassandra"; | |||
|
|||
// Step the schema version if schema is updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
loadFunction, | ||
Collections::emptyMap, //Consider creating bilk loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider as in "TODO", "FIX"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After investigating how the AuthCache is used in ecAudit and how the bulkloader could be used I don't think a bulkloader will work here.
static private IAuthorizer authorizerMock = mock(IAuthorizer.class); | ||
static private INetworkAuthorizer networkAuthorizerMock = mock(INetworkAuthorizer.class); | ||
|
||
private ClientInitializer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #217 +/- ##
============================================
+ Coverage 70.05% 71.09% +1.04%
+ Complexity 715 710 -5
============================================
Files 77 76 -1
Lines 2441 2391 -50
Branches 193 185 -8
============================================
- Hits 1710 1700 -10
+ Misses 702 662 -40
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed some comments
Closes #211