Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to decide reporting for metrics #394

Merged

Conversation

masokol
Copy link
Contributor

@masokol masokol commented Oct 17, 2022

Closes #390

@codecov-commenter
Copy link

Codecov Report

Merging #394 (4be6466) into master (5be5749) will decrease coverage by 0.19%.
The diff coverage is 64.91%.

@@             Coverage Diff              @@
##             master     #394      +/-   ##
============================================
- Coverage     77.07%   76.88%   -0.20%     
+ Complexity     1253     1252       -1     
============================================
  Files           130      130              
  Lines          5440     5481      +41     
  Branches        552      559       +7     
============================================
+ Hits           4193     4214      +21     
- Misses         1070     1081      +11     
- Partials        177      186       +9     
Impacted Files Coverage Δ
...ndra/ecchronos/application/ECChronosInternals.java 0.00% <0.00%> (ø)
...ecchronos/application/spring/BeanConfigurator.java 51.76% <50.00%> (-0.62%) ⬇️
...ecchronos/core/metrics/TableRepairMetricsImpl.java 69.87% <60.71%> (-10.13%) ⬇️
...cassandra/ecchronos/application/config/Config.java 94.04% <76.00%> (-2.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@masokol masokol merged commit dc97d15 into Ericsson:master Oct 18, 2022
@masokol masokol deleted the addPossibilityToDecideHowToReportMetrics branch October 18, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to turn off writing metrics to file but keep producing prometheus metrics
3 participants